linux-kernel - Re: [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140711181212.GT18735@two.firstfloor.org>
Date:	Fri, 11 Jul 2014 20:12:12 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Andi Kleen <andi@...stfloor.org>,
	Al Viro <viro@...IV.linux.org.uk>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext

> diff --git a/arch/x86/include/uapi/asm/sigcontext.h b/arch/x86/include/uapi/asm/sigcontext.h
> index 076b11f..df9908b 100644
> --- a/arch/x86/include/uapi/asm/sigcontext.h
> +++ b/arch/x86/include/uapi/asm/sigcontext.h

I don't think renaming fields in uapi/asm is acceptable. These
are likely used by user programs and you'll break compiles.

-Andi

> @@ -177,8 +177,8 @@ struct sigcontext {
>  	__u64 rip;
>  	__u64 eflags;		/* RFLAGS */
>  	__u16 cs;
> -	__u16 gs;
> -	__u16 fs;
> +	__u16 __pad2;		/* Was called gs, but was always zero. */
> +	__u16 __pad1;		/* Was called fs, but was always zero. */
>  	__u16 ss;
>  	__u64 err;
>  	__u64 trapno;

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/