linux-kernel - Re: i915: reduce noise from i915_gem_shrinker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 12 Jul 2014 11:50:25 -0400
From:	Dave Jones <davej@...hat.com>
To:	Chris Wilson <chris@...is-wilson.co.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: i915: reduce noise from i915_gem_shrinker_oom when no memory
 freed.

On Sat, Jul 12, 2014 at 11:23:43AM +0200, Daniel Vetter wrote:
 > On Fri, Jul 11, 2014 at 07:11:43AM +0100, Chris Wilson wrote:
 > > On Thu, Jul 10, 2014 at 11:05:05PM -0400, Dave Jones wrote:
 > > > When the shrinker doesn't free any memory, don't spew over and over
 > > > into the logs.  My fuzz tester hits this quite easily, resulting
 > > > in dozens of instances of this printk when memory runs low, filling
 > > > dmesg, when there's not even any graphical stuff going on, so the
 > > > situation would never change.
 > > 
 > > We still want to know when we failed to free anything though.
 > > 
 > > if (freed || unbound || bound)
 > > 	pr_info("Purging GPU memory...
 > > 
 > > should be a reasonable compromise.
 > 
 > Dave, would this work for you? Can you please submit it as a patch to
 > intel-gfx?

Will do when I get back on Monday.  I'm running my tests over the
weekend, looks ok so far.

thanks,

	Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/