lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 11 Jul 2014 17:47:39 -0700
From:	Greg Kroah-Hartman <>
To:	Daniel Thompson <>
Cc:,,, Jiri Slaby <>,
Subject: Re: [PATCH] tty: kgdb_nmi: Convert kgdb_nmi_tty_enabled into a
 module parameter

On Fri, Jul 11, 2014 at 01:30:11PM +0100, Daniel Thompson wrote:
> At present it is not possible to boot with the ttyNMI0 console treating
> character input normally. To use the console requires that kdb be
> entered and the nmi_console command be used to enable the console (or if
> only kgdb is present then gdb must directly manipulate the value of
> kgdb_nmi_tty_enabled).
> Introducing a module parameter makes the console much more usable.
> Signed-off-by: Daniel Thompson <>
> Cc: Greg Kroah-Hartman <>
> Cc: Jiri Slaby <>
> Cc:
> ---
>  drivers/tty/serial/kgdb_nmi.c | 5 +++++
>  1 file changed, 5 insertions(+)
> diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c
> index cfadf29..9361d69 100644
> --- a/drivers/tty/serial/kgdb_nmi.c
> +++ b/drivers/tty/serial/kgdb_nmi.c
> @@ -43,6 +43,11 @@ module_param_named(magic, kgdb_nmi_magic, charp, 0600);
>  MODULE_PARM_DESC(magic, "magic sequence to enter NMI debugger (default $3#33)");
>  static bool kgdb_nmi_tty_enabled;
> +module_param_named(tty, kgdb_nmi_tty_enabled, bool, 0600);
> +MODULE_PARM_DESC(tty, "if set to false (default), characters received from "
> +		      "the UART will be passed exclusively to the knock "
> +		      "detector; when set to true characters will be passed "
> +		      "both to the knock detector and to the TTY layer");

Module options suck rocks through straws.

Isn't there _any_ other way to determine this "dynamically"?  How will
someone know to set this option?

Yeah, there are other options in this module, but please, why add more?

greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists