linux-kernel - Re: [PATCH] staging: iio: adc: ad7192: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53C24D5E.6070204@kernel.org>
Date:	Sun, 13 Jul 2014 10:11:58 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Marcus Folkesson <marcus.folkesson@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sachin Kamat <sachin.kamat@...aro.org>
CC:	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: adc: ad7192: fix coding style

On 12/07/14 20:16, Marcus Folkesson wrote:
> Line over 80 characters. This is for Eudyptula Challenge.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
Sorry Marcus,

There is a level of trivial cleanup below which it's not worth
taking patches. The 80 character limit is not a hard and fast
rule. Here, if this had been picked up during review of the original
patch, or was fixed as a part of a more substantial series, I'd
have no objection taking it.  On it's own it's just too small.

Jonathan

> ---
>   drivers/staging/iio/adc/ad7192.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 83bb44b..c25c9ab 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -223,7 +223,8 @@ static int ad7192_setup(struct ad7192_state *st,
>   	id &= AD7192_ID_MASK;
>
>   	if (id != st->devid)
> -		dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n", id);
> +		dev_warn(&st->sd.spi->dev,
> +			"device ID query failed (0x%X)\n", id);
>
>   	switch (pdata->clock_source_sel) {
>   	case AD7192_CLK_EXT_MCLK1_2:
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/