linux-kernel - Re: [PATCH v2 1/2] xen: Silence compiler warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Jul 2014 05:59:18 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Daniel Kiper <daniel.kiper@...cle.com>,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	xen-devel@...ts.xenproject.org
CC:	andrew.cooper3@...rix.com, boris.ostrovsky@...cle.com,
	david.vrabel@...rix.com, hpa@...or.com, ian.campbell@...rix.com,
	jbeulich@...e.com, jeremy@...p.org, matt.fleming@...el.com,
	mingo@...hat.com, stefano.stabellini@...citrix.com,
	tglx@...utronix.de
Subject: Re: [PATCH v2 1/2] xen: Silence compiler warnings

On July 12, 2014 5:09:47 PM EDT, Daniel Kiper <daniel.kiper@...cle.com> wrote:
>Add inline keyword to silence the following compiler
>warnings if xen_efi_probe() is not used:
>
>  CC      arch/x86/xen/setup.o
>In file included from arch/x86/xen/xen-ops.h:7:0,
>                 from arch/x86/xen/setup.c:31:
>include/xen/xen-ops.h:43:35: warning: ‘xen_efi_probe’ defined but not
>used [-Wunused-function]
>
>Signed-off-by: Daniel Kiper <daniel.kiper@...cle.com>

Reviewed-by: Konrad Rzeszutek Wilk <Konrad.wilk@...cle.com>
>---
> include/xen/xen-ops.h |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>index 771bbba..7491ee5 100644
>--- a/include/xen/xen-ops.h
>+++ b/include/xen/xen-ops.h
>@@ -40,7 +40,7 @@ bool xen_running_on_version_or_later(unsigned int
>major, unsigned int minor);
> #ifdef CONFIG_XEN_EFI
> extern efi_system_table_t *xen_efi_probe(void);
> #else
>-static efi_system_table_t __init *xen_efi_probe(void)
>+static inline efi_system_table_t __init *xen_efi_probe(void)
> {
> 	return NULL;
> }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/