linux-kernel - Re: [PATCH 1/1] fs/exofs/ore_raid.c: replace count*size kzalloc by kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53C258F5.7070305@panasas.com>
Date:	Sun, 13 Jul 2014 13:01:25 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Fabian Frederick <fabf@...net.be>, <linux-kernel@...r.kernel.org>
CC:	<osd-dev@...n-osd.org>, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] fs/exofs/ore_raid.c: replace count*size kzalloc by
 kcalloc

On 06/25/2014 09:14 PM, Fabian Frederick wrote:
> kcalloc manages count*sizeof overflow.
> 
> Cc: Boaz Harrosh <bharrosh@...asas.com>
ACK-by: Boaz Harrosh <bharrosh@...asas.com>

Do you need that I submit this through my tree?

Thanks
Boaz
> Cc: osd-dev@...n-osd.org
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  fs/exofs/ore_raid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/exofs/ore_raid.c b/fs/exofs/ore_raid.c
> index 7f20f25..84529b8 100644
> --- a/fs/exofs/ore_raid.c
> +++ b/fs/exofs/ore_raid.c
> @@ -116,7 +116,7 @@ static int _sp2d_alloc(unsigned pages_in_unit, unsigned group_width,
>  			num_a1pa = min_t(unsigned, PAGE_SIZE / sizeof__a1pa,
>  							pages_in_unit - i);
>  
> -			__a1pa = kzalloc(num_a1pa * sizeof__a1pa, GFP_KERNEL);
> +			__a1pa = kcalloc(num_a1pa, sizeof__a1pa, GFP_KERNEL);
>  			if (unlikely(!__a1pa)) {
>  				ORE_DBGMSG("!! Failed to _alloc_1p_arrays=%d\n",
>  					   num_a1pa);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/