linux-kernel - Re: [PATCH] can: flexcan: add vf61x support for flexcan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7da069ecd355069d82cbe95adc1043f5@agner.ch>
Date:	Mon, 14 Jul 2014 09:10:54 +0200
From:	Stefan Agner <stefan@...er.ch>
To:	Shawn Guo <shawn.guo@...escale.com>
Cc:	Marc Kleine-Budde <mkl@...gutronix.de>, wg@...ndegger.com,
	kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
	linux-can@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: flexcan: add vf61x support for flexcan

Am 2014-07-14 09:06, schrieb Stefan Agner:
> Am 2014-07-14 08:04, schrieb Shawn Guo:
>> On Fri, Jul 11, 2014 at 03:58:37PM +0200, Stefan Agner wrote:
>>> >> @@ -362,7 +374,7 @@
>>> >>
>>> >>  			esdhc1: esdhc@...b2000 {
>>> >>  				compatible = "fsl,imx53-esdhc";
>>> >> -				reg = <0x400b2000 0x4000>;
>>> >> +				reg = <0x400b2000 0x1000>;
>>> >
>>> > What's that doing here? :)
>>>
>>> That's an error I just stumbled upon.
>>
>> I do not see why it's an error.  From Table 2-1. System Memory Map in
>> i.MX53 RM, the size of ESDHC1 is 16K.
>>
>> Shawn
> 
> But then, the memory map within the SDHC peripheral has some registers
> also located in 0x400B3000. Hence I think 0x2000 is correct. Will send
> an updated and separated patch.
> 

Sorry, I read this wrong. It is SDHC1 which is in the upper 0x1000 of
the memory map.

So I would say 0x1000 is really correct, since SDHC0 is at 0x400B1000
and SDHC1 is at 0x400B2000.

--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/