lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 14 Jul 2014 10:46:06 +0200
From:	Jan Kara <jack@...e.cz>
To:	Chao Yu <chao2.yu@...sung.com>
Cc:	jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] udf: avoid redundant memcpy when writing data in ICB

On Mon 30-06-14 13:37:15, Chao Yu wrote:
> We have already copied the changed data of page to extent area in ICB when call
> ->write_end() of adinicb aops, so we do not need to copy them another time in
> ->writepage() of adinicb aops. SetPageUptodate is redundant too, so it's better
> to remove these redundant codes.
> 
> Also it looks more reasonable to set inode dirty after extent area are modified,
> we'd better move mark_inode_dirty() from ->writepage() to ->write_end().
  This doesn't look right. The copy is there because the page can be
modified via mmap as well, not only via buffered write... So if anything,
we may be able to remove the copy in udf_adinicb_write_end() (actually
using directly simple_write_end() for that), not the one in
udf_adinicb_write_begin().

								Honza
> 
> Signed-off-by: Chao Yu <chao2.yu@...sung.com>
> ---
>  fs/udf/file.c |   12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/fs/udf/file.c b/fs/udf/file.c
> index d80738f..3cd0a50 100644
> --- a/fs/udf/file.c
> +++ b/fs/udf/file.c
> @@ -65,17 +65,7 @@ static int udf_adinicb_readpage(struct file *file, struct page *page)
>  static int udf_adinicb_writepage(struct page *page,
>  				 struct writeback_control *wbc)
>  {
> -	struct inode *inode = page->mapping->host;
> -	char *kaddr;
> -	struct udf_inode_info *iinfo = UDF_I(inode);
> -
>  	BUG_ON(!PageLocked(page));
> -
> -	kaddr = kmap(page);
> -	memcpy(iinfo->i_ext.i_data + iinfo->i_lenEAttr, kaddr, inode->i_size);
> -	mark_inode_dirty(inode);
> -	SetPageUptodate(page);
> -	kunmap(page);
>  	unlock_page(page);
>  
>  	return 0;
> @@ -115,6 +105,8 @@ static int udf_adinicb_write_end(struct file *file,
>  		kaddr + offset, copied);
>  	kunmap_atomic(kaddr);
>  
> +	mark_inode_dirty(inode);
> +
>  	return simple_write_end(file, mapping, pos, len, copied, page, fsdata);
>  }
>  
> -- 
> 1.7.9.5
> 
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists