linux-kernel - Re: [PATCH] xillybus: place 'else' on same line as '}'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Jul 2014 11:51:42 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Eli Billauer <eli.billauer@...il.com>
Cc:	Jeremiah Mahler <jmmahler@...il.com>, devel@...verdev.osuosl.org,
	Kees Cook <keescook@...omium.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	Richard Weinberger <richard@....at>
Subject: Re: [PATCH] xillybus: place 'else' on same line as '}'

On Mon, Jul 14, 2014 at 09:40:39AM +0300, Eli Billauer wrote:
> Hi,
> 
> Thanks for this.
> 
> And since I looked at the part in Codingstyle that deals with
> if-else, I found another few mistakes regarding braces around a
> single statement. The rules say, it turns out, that if one of the
> clauses in an if-else is longer than one statement, both clauses
> should be wrapped with braces. This rule is broken in lines 162, 536
> and 613 of the same file.
> 
> To avoid possible conflicts, I'll wait for this patch to be applied,
> and submit my corrections after that.

In theory there shouldn't be any need to wait because the rules about
which patches go in first are very clear and predictable.  First come
first serve.  Unless a patch is rejected.  And they are only rejected if
they violate some rule, but normally ok patches go in.

This patch is almost totally ok except it doesn't have "staging" in the
subject.  I'm not sure if that's enough to reject it...  Probably it's
ok and you should assume it will be merged.

The other reason that you don't need to wait is that this patch won't
conflict with the other patch you are proposing.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/