lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 13 Jul 2014 22:09:58 -0500
From:	Chase Southwood <>
To:	Hartley Sweeten <>
Cc:	"" <>,
	"" <>,
	"" <>,
	"" <>
Subject: Re: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog
 module to init watchdog subdevice

On Sun, Jul 13, 2014 at 2:17 PM, Hartley Sweeten
<> wrote:
> On Saturday, July 12, 2014 3:44 PM, Chase Southwood wrote:
>> Use the addi_watchdog module to provide support for the watchdog
>> subdevice.
>> Also, rearrange the subdevice init blocks so that the order makes sense.
>> Digital input/output subdevices and subdevices for DI/DO interrupt
>> support, followed by timer/counter/watchdog subdevices is the new order.
>> Signed-off-by: Chase Southwood <>
>> Cc: Ian Abbott <>
>> Cc: H Hartley Sweeten <>
>> ---
>>  drivers/staging/comedi/drivers/addi_apci_1564.c | 34 +++++++++++++++----------
>>  1 file changed, 20 insertions(+), 14 deletions(-)
> Chase,
> You should also add the dependency for the addi watchdog module
> to the Kconfig.

Hello, Hartley!

The select statement for COMEDI_ADDI_WATCHDOG was added to Kconfig for
the addi_apci_1564 driver in commit

From: Arnd Bergmann <>
Date: Tue, 3 Jun 2014 12:29:29 +0200
Subject: [PATCH] staging: comedi: addi_apci_1564: add addi_watchdog dependency

Signed-off-by: Arnd Bergmann <>
Cc: H Hartley Sweeten <>
Acked-by: Ian Abbott <>
Signed-off-by: Greg Kroah-Hartman <>

This is because the driver has already been using
addi_watchdog_reset() and I had forgotten to add the select to the
Kconfig when I added that function call, so Arnd added it when a
randconfig build error turned up later.  Sorry for the


> Regards,
> Hartley
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists