lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140714104255.GE30550@quack.suse.cz> Date: Mon, 14 Jul 2014 12:42:55 +0200 From: Jan Kara <jack@...e.cz> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] fs/udf: re-use hex_asc_upper_{hi,lo} macros On Wed 09-07-14 15:35:30, Andy Shevchenko wrote: > This patch cleans up udf_translate_to_linux() a bit by using globally defined > macros instead of custom code. > > We can use sprintf(buf, "%04X", ...) there as well, but this one faster. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Thanks. I've merged the patch. Honza > --- > fs/udf/unicode.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c > index 44b815e..afd470e 100644 > --- a/fs/udf/unicode.c > +++ b/fs/udf/unicode.c > @@ -412,7 +412,6 @@ static int udf_translate_to_linux(uint8_t *newName, uint8_t *udfName, > int extIndex = 0, newExtIndex = 0, hasExt = 0; > unsigned short valueCRC; > uint8_t curr; > - const uint8_t hexChar[] = "0123456789ABCDEF"; > > if (udfName[0] == '.' && > (udfLen == 1 || (udfLen == 2 && udfName[1] == '.'))) { > @@ -477,10 +476,10 @@ static int udf_translate_to_linux(uint8_t *newName, uint8_t *udfName, > newIndex = 250; > newName[newIndex++] = CRC_MARK; > valueCRC = crc_itu_t(0, fidName, fidNameLen); > - newName[newIndex++] = hexChar[(valueCRC & 0xf000) >> 12]; > - newName[newIndex++] = hexChar[(valueCRC & 0x0f00) >> 8]; > - newName[newIndex++] = hexChar[(valueCRC & 0x00f0) >> 4]; > - newName[newIndex++] = hexChar[(valueCRC & 0x000f)]; > + newName[newIndex++] = hex_asc_upper_hi(valueCRC >> 8); > + newName[newIndex++] = hex_asc_upper_lo(valueCRC >> 8); > + newName[newIndex++] = hex_asc_upper_hi(valueCRC); > + newName[newIndex++] = hex_asc_upper_lo(valueCRC); > > if (hasExt) { > newName[newIndex++] = EXT_MARK; > -- > 2.0.1 > -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists