linux-kernel - Re: [PATCH] ARM: avoid ARM binutils leaking ELF local symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87oaws457z.fsf@rustcorp.com.au>
Date:	Mon, 14 Jul 2014 19:44:40 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Russell King <rmk+kernel@....linux.org.uk>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: avoid ARM binutils leaking ELF local symbols

Russell King <rmk+kernel@....linux.org.uk> writes:
> Symbols starting with .L are ELF local symbols and should not appear
> in ELF symbol tables.  However, unfortunately ARM binutils leaks the
> .LANCHOR symbols into the symbol table, which leads kallsyms to report
> these symbols rather than the real name.  It is not very useful when
> %pf reports symbols against these leaked .LANCHOR symbols.
>
> Arrange for kallsyms to ignore these symbols using the same mechanism
> that is used for the ARM mapping symbols.

Yech... Applied.

Thanks,
Rusty.

> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> ---
>  kernel/module.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 81e727cf6df9..cecd78d06025 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3385,6 +3385,8 @@ static inline int within(unsigned long addr, void *start, unsigned long size)
>   */
>  static inline int is_arm_mapping_symbol(const char *str)
>  {
> +	if (str[0] == '.' && str[1] == 'L')
> +		return true;
>  	return str[0] == '$' && strchr("atd", str[1])
>  	       && (str[2] == '\0' || str[2] == '.');
>  }
> -- 
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/