linux-kernel - Re: [PATCH] ARM: EXYNOS: Fix MCPM build with SUSPEND=n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1407140730080.3647@knanqh.ubzr>
Date:	Mon, 14 Jul 2014 07:35:15 -0400 (EDT)
From:	Nicolas Pitre <nicolas.pitre@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
cc:	Russell King <linux@....linux.org.uk>,
	Kukjin Kim <kgene.kim@...sung.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tomasz Figa <t.figa@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] ARM: EXYNOS: Fix MCPM build with SUSPEND=n

On Mon, 14 Jul 2014, Krzysztof Kozlowski wrote:

> Building of EXYNOS5420_MCPM with disabled SUSPEND fails:
> arch/arm/mach-exynos/built-in.o: In function `exynos_mcpm_init':
> arch/arm/mach-exynos/mcpm-exynos.c:361: undefined reference to `mcpm_loopback'
> 
> The exynos_mcpm_init() in mcp-exynos.c calls mcpm_loopback() which
> depends on cpu_suspend function (ARM_CPU_SUSPEND).
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Cc: <stable@...r.kernel.org>

No need to CC stable here as this code has not reached a released kernel 
yet.

> Fixes: a6a4d3152e3cbb6 ("ARM: 8083/1: exynos: activate the CCI on boot CPU/cluster using the MCPM loopback")

And this is not clear yet if this commit ID is stable.

Other than that:

Acked-by: Nicolas Pitre <nico@...aro.org>

Please send to RMK's patch system.


> ---
>  arch/arm/mach-exynos/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 8f9b66c4ac78..5d4ff6571dcd 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -119,6 +119,7 @@ config EXYNOS5420_MCPM
>  	bool "Exynos5420 Multi-Cluster PM support"
>  	depends on MCPM && SOC_EXYNOS5420
>  	select ARM_CCI
> +	select ARM_CPU_SUSPEND
>  	help
>  	  This is needed to provide CPU and cluster power management
>  	  on Exynos5420 implementing big.LITTLE.
> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/