linux-kernel - Re: [PATCH 2/2] USB: add reset resume quirk for usb3503

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <53C3C5C2.1020300@samsung.com>
Date:	Mon, 14 Jul 2014 13:57:54 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	Joonyoung Shim <jy0922.shim@...sung.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	gregkh@...uxfoundation.org, broonie@...aro.org, tobetter@...il.com
Subject: Re: [PATCH 2/2] USB: add reset resume quirk for usb3503

Hello,

On 2014-07-10 07:22, Joonyoung Shim wrote:
> The usb device will autoresume from choose_wakeup() if it is
> autosuspended with the wrong wakeup setting, but below errors occur
> because usb3503 misc driver will switch to standby mode when suspended.
>
> As add USB_QUIRK_RESET_RESUME, it can stop setting wrong wakeup from
> autosuspend_check().
>
> [    7.734717] usb 1-3: reset high-speed USB device number 3 using exynos-ehci
> [    7.854658] usb 1-3: device descriptor read/64, error -71
> [    8.079657] usb 1-3: device descriptor read/64, error -71
> [    8.294664] usb 1-3: reset high-speed USB device number 3 using exynos-ehci
> [    8.414658] usb 1-3: device descriptor read/64, error -71
> [    8.639657] usb 1-3: device descriptor read/64, error -71
> [    8.854667] usb 1-3: reset high-speed USB device number 3 using exynos-ehci
> [    9.264598] usb 1-3: device not accepting address 3, error -71
> [    9.374655] usb 1-3: reset high-speed USB device number 3 using exynos-ehci
> [    9.784601] usb 1-3: device not accepting address 3, error -71
> [    9.784838] usb usb1-port3: device 1-3 not suspended yet
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@...sung.com>

Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>

> ---
>   drivers/usb/core/quirks.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 739ee8e..2c9ba407 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -152,6 +152,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>   	/* INTEL VALUE SSD */
>   	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>   
> +	/* USB3503 */
> +	{ USB_DEVICE(0x0424, 0x3503), .driver_info = USB_QUIRK_RESET_RESUME },
> +
>   	{ }  /* terminating entry must be last */
>   };
>   

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/