linux-kernel - Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140714124336.GA1763@arch.cereza>
Date:	Mon, 14 Jul 2014 09:43:36 -0300
From:	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
To:	Nicolas Del Piano <ndel314@...il.com>
Cc:	rjw@...ysocki.net, viresh.kumar@...aro.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP

Nico,

On 13 Jul 06:59 PM, Nicolas Del Piano wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
> 
> Reported-by: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
> Signed-off-by: Nicolas Del Piano <ndel314@...il.com>

Thanks for the patch. I have just a very minor nitpick to comment;
if you run a git log, you'll see the subject should be:

"cpufreq: imx6q: Select PM_OPP"

In general, it's better to see the recent commits to find out how to write
the commit title; each driver can have its own style.
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/