linux-kernel - Re: [PATCH] Staging: rtl8821ae: fix coding style issue in cam.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140714132633.GA8144@kroah.com>
Date:	Mon, 14 Jul 2014 06:26:33 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"Joerg C. Meyer" <joerg@...er.homedns.org>
Cc:	dingtianhong@...wei.com, chenweilong@...wei.com,
	sachin.kamat@...aro.org, davem@...emloft.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8821ae: fix coding style issue in cam.c

On Mon, Jul 14, 2014 at 11:42:33AM +0200, Joerg C. Meyer wrote:
> This is a patch to the cam.c file that fix a coding style error (do not use C99 // comments)
> Signed-off-by: Joerg C. Meyer <joerg@...er.homedns.org>

Minor nit, you need a blank line between these two lines...

> ---
>  drivers/staging/rtl8821ae/cam.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c
> index 3bc6b3d..9c0cd1e 100644
> --- a/drivers/staging/rtl8821ae/cam.c
> +++ b/drivers/staging/rtl8821ae/cam.c
> @@ -152,7 +152,7 @@ u8 rtl_cam_add_one_entry(struct ieee80211_hw *hw, u8 *mac_addr,
>  	return 1;
>  
>  }
> -//EXPORT_SYMBOL(rtl_cam_add_one_entry);
> +/* EXPORT_SYMBOL(rtl_cam_add_one_entry); */

Your patch is correct, but how about just deleting these lines instead?
They aren't needed, so please remove them.

Can you do that and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/