linux-kernel - Re: [PATCH 1/4 V3] irqchip: gic: Add binding probe for ARM GIC400

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2932284.F1eaAf8ArJ@diego>
Date:	Mon, 14 Jul 2014 16:03:15 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	suravee.suthikulpanit@....com, jason@...edaemon.net
Cc:	linux-arm-kernel@...ts.infradead.org, marc.zyngier@....com,
	mark.rutland@....com, devicetree@...r.kernel.org,
	pawel.moll@....com, linux-doc@...r.kernel.org,
	Catalin.Marinas@....com, Harish.Kasiviswanathan@....com,
	linux-kernel@...r.kernel.org, Will.Deacon@....com,
	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
	linux-pci@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH 1/4 V3] irqchip: gic: Add binding probe for ARM GIC400

Am Mittwoch, 9. Juli 2014, 18:05:01 schrieb suravee.suthikulpanit@....com:
> From: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
> 
> Add new Irqchip declaration for GIC400. This was mentioned in
> gic binding documentation, but there is not code to support it.
> 
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>

The Rockchip RK3288 also contains a GIC400, so I would be very happy if 
someone could pick up this one patch independently of the rest.

But in light of Matthias' cortex-a7-gic patch from last week, this one might 
need an update.


> ---
>  drivers/irqchip/irq-gic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> index 508b815..ac8f7ea 100644
> --- a/drivers/irqchip/irq-gic.c
> +++ b/drivers/irqchip/irq-gic.c
> @@ -1020,6 +1020,8 @@ gic_of_init(struct device_node *node, struct
> device_node *parent) gic_cnt++;
>  	return 0;
>  }
> +

also it looks like the omission of the blank line in the original file is 
intentional, so I'd guess it shouldn't be added here.


> +IRQCHIP_DECLARE(arm_gic_400, "arm,gic-400", gic_of_init);
>  IRQCHIP_DECLARE(cortex_a15_gic, "arm,cortex-a15-gic", gic_of_init);
>  IRQCHIP_DECLARE(cortex_a9_gic, "arm,cortex-a9-gic", gic_of_init);
>  IRQCHIP_DECLARE(msm_8660_qgic, "qcom,msm-8660-qgic", gic_of_init);


Thanks
Heiko

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/