linux-kernel - Re: [PATCH v2] hwmon: pwm-fan: Add pwm-fan driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140714142525.GB7668@distanz.ch>
Date:	Mon, 14 Jul 2014 16:25:25 +0200
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Kamil Debski <k.debski@...sung.com>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	lm-sensors@...sensors.org, t.figa@...sung.com,
	m.szyprowski@...sung.com, linux@...ck-us.net,
	linux-pwm@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: pwm-fan: Add pwm-fan driver

On 2014-07-14 at 15:50:35 +0200, Kamil Debski <k.debski@...sung.com> wrote:
> The pwm-fan driver enables control of fans connected to PWM lines.
> This driver uses the PWM framework, so it is compatible with all
> PWM devices that provide drivers through the PWM framework.
> 
> Signed-off-by: Kamil Debski <k.debski@...sung.com>
> ---
> Changes since v1:
> - added documentation to Documentation/hwmon
> - fix checkpatch errors
> 	- added extra description to Kconfig
> 	- removed whitespace errors
> - include files rearranged to be in alphabetical order
> - remove unused sysfs entry pwm1_enable
> - changed the behavior of the set_pwm function
> 	- when 0 PWM value is set pwm_disable is run
> 	- pwm_config return value is checked for errors
> - use of ATTRIBUTE_GROUPS was added
> - removed "Not enouch memory" error message
> - fixed probe return value in case of devm_of_pwm_get error
> - changed hwmon_device_register_with_groups to
>   devm_hwmon_device_register_with_groups
> - changes suspend/resume to use pwm_disable/enable
> - removed unnecessary CONFIG_PM_SLEEP ifdefs

pwm_fan_suspend and pwm_fan_resume should still be enclosed in #ifdef
CONFIG_PM_SLEEP, otherwise you'll get 'defined but not used' compiler
warnings when building without CONFIG_PM being set.

Cheers
Tobias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/