linux-kernel - Re: [PATCH] libata: handle IDE AMNF errors in the EH path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140714161010.GE31610@htj.dyndns.org>
Date:	Mon, 14 Jul 2014 12:10:10 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Alexey Asemov <alex@...x-at.ru>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libata: handle IDE AMNF errors in the EH path

On Sat, Jul 12, 2014 at 12:22:53PM +0400, Alexey Asemov wrote:
> libata-eh.c should handle AMNF error condition (error byte bit 0, usually
> code 0x01) in libata-eh.c along with UNC as a media error so SCSI stack
> can handle it properly (translation code 0x01 is already present in
> libata-scsi.c) but was never passed down due to lack of handling in EH.

IIRC AMNF has been deprecated for a very long time now.  The bit isn't
too likely to get reused given that major updates to ATA spec is
improbable but I'm still not quite fond of adding handling of a long
deprecated flag.  Can you please provide a bit more detail?  Which
device was it?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/