lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Jul 2014 09:14:41 -0700 From: Andy Lutomirski <luto@...capital.net> To: Peter Zijlstra <peterz@...radead.org> Cc: Jiri Olsa <jolsa@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Arnaldo Carvalho de Melo <acme@...nel.org>, Corey Ashford <cjashfor@...ux.vnet.ibm.com>, David Ahern <dsahern@...il.com>, Frederic Weisbecker <fweisbec@...il.com>, Ingo Molnar <mingo@...nel.org>, Namhyung Kim <namhyung@...nel.org>, Paul Mackerras <paulus@...ba.org>, "H. Peter Anvin" <hpa@...ux.intel.com> Subject: Re: [PATCH] perf: Add vm_ops->name call for mmap event name retrieval On Mon, Jul 14, 2014 at 9:09 AM, Peter Zijlstra <peterz@...radead.org> wrote: > On Mon, Jul 14, 2014 at 05:57:19PM +0200, Jiri Olsa wrote: >> Following patch added another way to get mmap name: >> 78d683e mm, fs: Add vm_ops->name as an alternative to arch_vma_name > > Please add to your .gitconfig: > > [core] > abbrev = 12 > > Also, you failed to CC the two people involved in that. > >> The vdso vma mapping already switch to this and we no longer >> get vdso name via arch_vma_name function. Adding this way to >> the perf mmap event name retrieval code. >> >> Caught this via perf test: >> >> $ sudo ./perf test -v 7 >> 7: Validate PERF_RECORD_* events & perf_sample fields : >> --- start --- >> >> SNIP >> >> PERF_RECORD_MMAP for [vdso] missing! >> test child finished with 255 >> ---- end ---- >> Validate PERF_RECORD_* events & perf_sample fields: FAILED! >> >> Cc: Arnaldo Carvalho de Melo <acme@...nel.org> >> Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com> >> Cc: David Ahern <dsahern@...il.com> >> Cc: Frederic Weisbecker <fweisbec@...il.com> >> Cc: Ingo Molnar <mingo@...nel.org> >> Cc: Namhyung Kim <namhyung@...nel.org> >> Cc: Paul Mackerras <paulus@...ba.org> >> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl> >> Signed-off-by: Jiri Olsa <jolsa@...nel.org> >> --- >> kernel/events/core.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/kernel/events/core.c b/kernel/events/core.c >> index 67e3b9c..4799676 100644 >> --- a/kernel/events/core.c >> +++ b/kernel/events/core.c >> @@ -5266,6 +5266,12 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event) >> >> goto got_name; >> } else { >> + if (vma->vm_ops && vma->vm_ops->name) { >> + name = (char *) vma->vm_ops->name(vma); >> + if (name) >> + goto cpy_name; >> + } >> + Looks good to me. Sorry I missed that. --Andy >> name = (char *)arch_vma_name(vma); >> if (name) >> goto cpy_name; >> -- >> 1.8.3.1 >> -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists