linux-kernel - Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Jul 2014 20:09:27 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
	Malcolm Priestley <tvboxspy@...il.com>,
	kernel-janitors@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Forest Bond <forest@...ttletooquiet.net>
Subject: Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

On Mon, Jul 14, 2014 at 07:01:37PM +0200, Peter Senna Tschudin wrote:
> <note>
> I'm not trying to push my changes over the rules. I'm trying to
> understand the problem, to avoid creating similar noise in the future.
> </note>
> 
> Now I understand that the problem with the series of 4 patches is that
> the subject is the same on the 4 patches. Having the same subject in 4
> patches is not good. I got this one.
> 
> But I have no clue why joining 4 cleanup patches into 1 is bad. The
> patches are all for the same driver, are all silencing checkpatch
> warnings, and even the typedef stuff was reported by checkpatch. The
> commit message of the single patch describes it all. If the subject of
> the series is the problem, why not make a single patch instead of a
> series of similar patches? It made sense from my perspective. So what
> is the problem in re-submit 4 similar patches as a single patch?

The one thing per patch rule is a bit ambiguous, but normally we auto
reject patches which "fix every checkpatch warning in somefile_foo.c"
and sugest that they instead be broken into one type of fix per patch.

Breaking it up like this is maybe not always beautiful but it's simple
to explain to newbies and generally easier to review.

If there are very few warnings in the file then "fix everything" is ok.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/