linux-kernel - Re: [PATCH 4/7] tracing: kill call_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140714150327.01fefa69@gandalf.local.home>
Date:	Mon, 14 Jul 2014 15:03:27 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Tom Zanussi <tom.zanussi@...ux.intel.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] tracing: kill call_filter_disable()

On Fri, 11 Jul 2014 21:06:47 +0200
Oleg Nesterov <oleg@...hat.com> wrote:

> It seems that the only purpose of call_filter_disable() is to
> make filter_disable() less clear and symmetrical, remove it.

But what will replace the purpose of making it less symmetrical and
clear?

This is the result of modifications over time.

-- Steve

> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
> ---
>  kernel/trace/trace_events_filter.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
> index 1edec32..54a125c 100644
> --- a/kernel/trace/trace_events_filter.c
> +++ b/kernel/trace/trace_events_filter.c
> @@ -774,17 +774,12 @@ static void __free_preds(struct event_filter *filter)
>  	filter->n_preds = 0;
>  }
>  
> -static void call_filter_disable(struct ftrace_event_call *call)
> -{
> -	call->flags &= ~TRACE_EVENT_FL_FILTERED;
> -}
> -
>  static void filter_disable(struct ftrace_event_file *file)
>  {
>  	struct ftrace_event_call *call = file->event_call;
>  
>  	if (call->flags & TRACE_EVENT_FL_USE_CALL_FILTER)
> -		call_filter_disable(call);
> +		call->flags &= ~TRACE_EVENT_FL_FILTERED;
>  	else
>  		file->flags &= ~FTRACE_EVENT_FL_FILTERED;
>  }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/