lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Jul 2014 00:08:37 +0200 From: Stephane Eranian <eranian@...gle.com> To: Andi Kleen <ak@...ux.intel.com> Cc: Andi Kleen <andi@...stfloor.org>, Peter Zijlstra <peterz@...radead.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store Andi, On Mon, Jul 14, 2014 at 9:24 PM, Andi Kleen <ak@...ux.intel.com> wrote: >> You could do better if you tagged the event during setup as load vs. store. >> And then you could simply propagate the flag to the data source struct. > > This would require listing all PEBS events in the table again. > The whole point of the other patch was to get rid of that. > > Besides it wouldn't work for a range of events (like UOPS_RETIRED.ALL) > I have a problem with this patch. It makes: perf mem -t store rec record OP_NA for the store. It was recording OP_STORE before. I think we need to keep LD/ST info. This is useful for analysis especially if we collect loads/stores simultaneously. Was working before for the mem-loads, mem-stores events. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists