linux-kernel - Re: [PATCH v3 2/2] devicetree: Add Cadence WDT devicetree bindings documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFcVECJ+tO4U5H2QvuY8xpkh5FrX_PtCvrH8FsZQ28bJwYRckA@mail.gmail.com>
Date:	Tue, 15 Jul 2014 14:34:06 +0530
From:	Harini Katakam <harinikatakamlinux@...il.com>
To:	Mark Rutland <mark.rutland@....com>
Cc:	"wim@...ana.be" <wim@...ana.be>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"rob@...dley.net" <rob@...dley.net>,
	"michals@...inx.com" <michals@...inx.com>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"harini.katakam@...inx.com" <harini.katakam@...inx.com>
Subject: Re: [PATCH v3 2/2] devicetree: Add Cadence WDT devicetree bindings documentation

Hi Mark,

On Tue, Jul 15, 2014 at 2:29 PM, Mark Rutland <mark.rutland@....com> wrote:
> On Tue, Jul 15, 2014 at 07:39:40AM +0100, Harini Katakam wrote:
>> Hi Mark,
>>
>> On Mon, Jul 14, 2014 at 8:37 PM, Mark Rutland <mark.rutland@....com> wrote:
>> > On Mon, Jul 14, 2014 at 01:16:09PM +0100, Harini Katakam wrote:
>> >> Add cadence-wdt bindings documentation.
>> >>
>> >> Signed-off-by: Harini Katakam <harinik@...inx.com>
>> >> ---
>> >>
>> >> v3 changes:
>> >> - Change reset property type and improve description.
>> >> - Improve description of clocks and interrupts.
>> >> - Use watchdog@ in the example.
>> >> - Use only cdns compatible string for now.
>> >>
>> >> v2:
>> >> No changes
>> >>
>> >> ---
>> >>  .../devicetree/bindings/watchdog/cadence-wdt.txt   |   27 ++++++++++++++++++++
>> >>  1 file changed, 27 insertions(+)
>> >>  create mode 100644 Documentation/devicetree/bindings/watchdog/cadence-wdt.txt
>> >>

<snip>

>> >> +Optional properties
>> >> +- reset                      : If this property exists, then a reset is done
>> >> +                       when watchdog times out.
>> >
>> > That's a bit of an ambiguous name (too easy to misconstrue as a reset
>> > device reference). Do any other watchdogs have similar properties?
>>
>> I could change it to "reset-on-timeout" if that better.
>> From the documentation of other drivers, there seems to be a reset-type
>> property in atmel. Dint find any other reset related properties.
>>
>
> Ok. reset-on-timeout sounds like a better property name to avoid
> possible confusion.
>
> That said, what happens if we don't specify the device should reset the
> system (but have a timeout-sec property)?
>

A reset wont be done but a message will be printed when the watchdog times out
just as an indication.

Regards,
Harini
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/