linux-kernel - Re: [PATCH 1/1] driver/tty: Fix a warning in check_tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C4F154.3000009@suse.cz>
Date:	Tue, 15 Jul 2014 11:16:04 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	"Li, ZhenHua" <zhen-hual@...com>,
	Peter Hurley <peter@...leysoftware.com>
CC:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] driver/tty: Fix a warning in check_tty_count

Hi,

On 07/15/2014 11:08 AM, Li, ZhenHua wrote:
> This bug  was founded in RHEL 6, kernel version 2.6.32.
> 
> But I also checked the file tty_io.c in  latest kernel, not all the code
> protected by tty_lock(tty).
> 
> For example,  in function tty_del_file,
> 
>     if (--tty->count < 0) {
>     }
> and
>     tty_del_file(filp);
> are not surrounded by tty_lock(tty).

Sure, but there is tty_lock_pair instead.

> So I think the new lock is necessary.

Nope, sorry, you have to complain to RedHat about this kernel. Unless
you can reproduce this with the vanilla kernel.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/