linux-kernel - Re: [PATCH v2 12/29] nios2: Interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5170097.X9RFbxSEnp@wuerfel>
Date:	Tue, 15 Jul 2014 11:27:55 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Ley Foon Tan <lftan@...era.com>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, lftan.linux@...il.com,
	cltang@...esourcery.com
Subject: Re: [PATCH v2 12/29] nios2: Interrupt handling

On Tuesday 15 July 2014 16:45:39 Ley Foon Tan wrote:
> +#ifndef _ASM_NIOS2_IRQ_H
> +#define _ASM_NIOS2_IRQ_H
> +
> +#define NIOS2_CPU_NR_IRQS	32
> +/* Reserve 32 additional interrupts for GPIO IRQs */
> +#define NR_IRQS			(NIOS2_CPU_NR_IRQS + 32)

Is this intentional? I would expect that you use SPARSE_IRQ
instead and not define NR_IRQS.

> +#ifndef NO_IRQ
> +#define NO_IRQ			(-1)
> +#endif

New architectures should no longer define NO_IRQ. Please fix all users
you encounter instead.

> diff --git a/arch/nios2/kernel/irq.c b/arch/nios2/kernel/irq.c
> new file mode 100644
> index 0000000..8770d50
> --- /dev/null
> +++ b/arch/nios2/kernel/irq.c
> +#include <linux/init.h>
> +#include <linux/interrupt.h>
> +#include <linux/of.h>

Maybe move this into drivers/irqchip/? Probably doesn't matter either way,
your choice.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/