linux-kernel - Re: [PATCH] fs/ext4/super.c: Let 'counters' switched by SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140715093154.GB1451@thunk.org>
Date:	Tue, 15 Jul 2014 05:31:54 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/ext4/super.c: Let 'counters' switched by SMP

On Tue, Jul 15, 2014 at 09:05:29AM +0800, Chen Gang wrote:
> When SMP is disabled, 'struct percpu_counter' has no 'counters' member,
> so need skip it when in !SMP.
> 
> The related git commit:
> 
>   "feab139 ext4: rearrange initialization to fix EXT4FS_DEBUG".
> 
> The related error (with allmodconfig under score):
> 
>     CC [M]  fs/ext4/super.o
>   fs/ext4/super.c: In function 'ext4_commit_super':
>   fs/ext4/super.c:4546:41: error: 'struct percpu_counter' has no member named 'counters'
>     if (EXT4_SB(sb)->s_freeclusters_counter.counters)
>                                            ^
>   fs/ext4/super.c:4550:39: error: 'struct percpu_counter' has no member named 'counters'
>     if (EXT4_SB(sb)->s_freeinodes_counter.counters)

Thanks for the pointing out the problem.  I though think the right way
of fixing this problem, though, instead of using the #ifdef
CONFIG_SMP, is to do this:

       if (percpu_counter_initialized(&EXT4_SB(sb)->s_freeclusters_counter))
       	  ...

I'll respin the "ext4: rearrange initialization to fix EXT4FS_DEBUG"
commit to include this fix and give you credit in the commit logs for
pointing out this issue.

Cheers,

						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/