lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Jul 2014 12:03:28 +0200 (CEST) From: Thomas Gleixner <tglx@...utronix.de> To: Ley Foon Tan <lftan@...era.com> cc: linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, lftan.linux@...il.com, cltang@...esourcery.com Subject: Re: [PATCH v2 21/29] nios2: Futex operations On Tue, 15 Jul 2014, Ley Foon Tan wrote: +static inline int atomic_futex_op_xchg_set(int oparg, u32 __user *uaddr, > + int *oldval) > +{ > + unsigned long flags; > + int ret; > + > + local_irq_save(flags); > + > + ret = get_user(*oldval, uaddr); > + if (!ret) > + ret = put_user(oparg, uaddr); This is wrong as it gets. get_user() might fault and sleep. You need a proper implementation, which handles fault exceptions. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists