linux-kernel - Re: [PATCH v2 06/29] nios2: I/O Mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2014 18:51:16 +0800
From:	Ley Foon Tan <lftan@...era.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Linux-Arch <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Chung-Lin Tang <cltang@...esourcery.com>
Subject: Re: [PATCH v2 06/29] nios2: I/O Mapping

On Tue, Jul 15, 2014 at 5:22 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 15 July 2014 16:45:33 Ley Foon Tan wrote:
>> +#ifdef __IO_USE_DUFFS
>> +
>> +/* Use "Duff's Device" to unroll the loops. */
>> +#define __IO_OUT_LOOP(a, b, l)                               \
>> +     do {                                            \
>
> The I/O loops can probably better go into the C file that uses them.
Okay.


>
> These should either use inline functions or macros that behave like them,
> to avoid miscompilation. The normal way to define those macros is
>
> #define inb(a) ({ 0; })
> #define outb(x, a) do { } while (0)
Okay, will update these.

>
>> +static inline void __iomem *ioremap_writethrough(unsigned long physaddr,
>> +                                             unsigned long size)
>> +{
>> +     return __ioremap(physaddr, size, 0);
>> +}
>
> ioremap_writethrough() is not a standard interface, just drop it.
Okay, will drop this.
>
>> +static inline void __iomem *ioremap_fullcache(unsigned long physaddr,
>> +                                             unsigned long size)
>> +{
>> +     return __ioremap(physaddr, size, _PAGE_CACHED);
>> +}
>
> This is more commonly called ioremap_cache().
>
> ioremap_fullcache() is defined on some architectures but never used. If
> you don't use this in your own code, you can drop it as well.

We are not using ioremap_fullcache(), will drop it.

Thanks.

Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/