linux-kernel - Re: [PATCH v3 3/4] can: flexcan: switch on clocks before accessing ecr register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140715155426.3c03f0d8@ipc1.ka-ro>
Date:	Tue, 15 Jul 2014 15:54:26 +0200
From:	Lothar Waßmann <LW@...O-electronics.de>
To:	Stefan Agner <stefan@...er.ch>
Cc:	shawn.guo@...escale.com, mkl@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] can: flexcan: switch on clocks before accessing
 ecr register

Hi,

Stefan Agner wrote:
> Reported-by: Ashutosh Singh <ashuleapyear@...il.com>
> Suggested-by: Marc Kleine-Budde <mkl@...gutronix.de>
> [stefan@...er.ch: added return check for clk_enable_prepare]
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
>  drivers/net/can/flexcan.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index f425ec2..89745aa 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -383,12 +383,26 @@ static int flexcan_get_berr_counter(const struct net_device *dev,
>  {
>  	const struct flexcan_priv *priv = netdev_priv(dev);
>  	struct flexcan_regs __iomem *regs = priv->base;
> -	u32 reg = flexcan_read(&regs->ecr);
> +	u32 reg, err;
> +
> +	err = clk_prepare_enable(priv->clk_ipg);
> +	if (err)
> +		return err;
> +
> +	err = clk_prepare_enable(priv->clk_per);
> +	if (err)
> +		goto out_disable_ipg;
> +
> +	reg = flexcan_read(&regs->ecr);
>  
flexcan_get_berr_counter() may be called from interrupt context and
thus must not call any functions that can sleep.
Compiling the driver with CONFIG_DEBUG_ATOMIC_SLEEP would catch this!


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@...o-electronics.de
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/