linux-kernel - Re: [PATCH V4 5/6] staging: vt6556: Cleanup indentation on statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2014 08:07:38 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	forest@...ttletooquiet.net, tvboxspy@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH V4 5/6] staging: vt6556: Cleanup indentation on statements

On Mon, Jul 14, 2014 at 09:15:32PM +0200, Peter Senna Tschudin wrote:
> Use tabs instead of spaces in a set of statements and fix lines
> over 80 chars. Reported by checkpatch.
> 
> Tested by compilation only.
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
> Cahnges from V3:
>  - Splitted the patches by change type
> 
>  drivers/staging/vt6656/main_usb.c | 44 ++++++++++++++++++++-------------------
>  1 file changed, 23 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 553a8e9..cc0281a 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -382,38 +382,40 @@ static int device_init_registers(struct vnt_private *pDevice)
>  	/* load vt3266 calibration parameters in EEPROM */
>  	if (pDevice->byRFType == RF_VT3226D0) {
>  		if ((pDevice->abyEEPROM[EEP_OFS_MAJOR_VER] == 0x1) &&
> -			(pDevice->abyEEPROM[EEP_OFS_MINOR_VER] >= 0x4)) {
> +		   (pDevice->abyEEPROM[EEP_OFS_MINOR_VER] >= 0x4)) {

Shouldn't this be indented by 1 more space?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/