linux-kernel - Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140715152929.GA8844@kroah.com>
Date:	Tue, 15 Jul 2014 08:29:29 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	lidza.louina@...il.com, markh@...pro.net,
	devel@...verdev.osuosl.org, driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote:
> The dgap_err() is printing a message with pr_err(),
> so all those are replaced.
> 
> Use definition "pr_fmt" and then all of "dgap:" in
> the beginning of print messages are removed.
> 
> And also removed "out of memory" message because
> the kernel has own message for that.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
> V2: use pr_fmt "dgap:" prefix on print message on dgap.
>     remove "out of memory" message.
> 
>     Adds Mark to TO list and CC list for checking send
>     this email properly to him.
> 
>  drivers/staging/dgap/dgap.c |  306 +++++++++++++++++++------------------------
>  1 files changed, 133 insertions(+), 173 deletions(-)
> 
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index 06c55cb..9e750fb 100644
> --- a/drivers/staging/dgap/dgap.c
> +++ b/drivers/staging/dgap/dgap.c
> @@ -41,6 +41,8 @@
>   */
>  #undef DIGI_CONCENTRATORS_SUPPORTED
>  
> +#define pr_fmt(fmt) "dgap: " fmt
> +
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> @@ -153,7 +155,6 @@ static void dgap_firmware_reset_port(struct channel_t *ch);
>  static int dgap_gettok(char **in);
>  static char *dgap_getword(char **in);
>  static int dgap_checknode(struct cnode *p);
> -static void dgap_err(char *s);
>  
>  /*
>   * Function prototypes from dgap_sysfs.h
> @@ -815,7 +816,7 @@ static struct board_t *dgap_found_board(struct pci_dev *pdev, int id,
>  	if (ret)
>  		goto free_brd;
>  
> -	pr_info("dgap: board %d: %s (rev %d), irq %ld\n",
> +	pr_info("board %d: %s (rev %d), irq %ld\n",
>  		boardnum, brd->name, brd->rev, brd->irq);

Almost all of the pr_*() calls in this driver should be converted over
to use dev_*() calls instead.  And some of them, like this one, should
be removed entirely (no need for a driver to be "noisy" when a device
for it is found, it should be quiet if at all possible, unless something
went wrong.)

So can you do that here instead?  I've applied the earlier patches in
this series, and stopped here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/