lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Jul 2014 09:12:51 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Catalin Marinas <catalin.marinas@....com> Cc: "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Wim Van Sebroeck <wim@...ana.be>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Will Deacon <Will.Deacon@....com>, Arnd Bergmann <arnd@...db.de>, Heiko Stuebner <heiko@...ech.de>, Russell King <linux@....linux.org.uk>, Jonas Jensen <jonas.jensen@...il.com>, Randy Dunlap <rdunlap@...radead.org>, Andrew Morton <akpm@...ux-foundation.org>, Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...nel.org>, Dmitry Eremin-Solenikov <dbaryshkov@...il.com>, David Woodhouse <dwmw2@...radead.org>, Tomasz Figa <t.figa@...sung.com>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v4 1/7] kernel: Add support for restart notifier call chain On Mon, Jul 14, 2014 at 07:58:59AM -0700, Guenter Roeck wrote: > On 07/14/2014 07:53 AM, Catalin Marinas wrote: [ ... ] > > > >I'm not fully convinced implying a 'notifier' is the right approach > >here. By analogy with the reboot notifier, this is something drivers > >would want to know about and do some work before the actual system > >restart (e.g. disable watchdogs as in the reboot notifier case). The > >restart notifier here is meant to perform the actual system restart. > >Arguably, the actual restart should be handled by priority 0 with some > >preparation before but we have reboot notifier already, so I don't think > >it's worth another notifier. > > > >While re-using the notifier mechanism behind the scene is fine, I think > >we should at least rename the functions to something like > >(un)register_restart_handler(). > > > > Fine with me. Any other comments / suggestions on the name of the function ? > Any further feedback on the function names ? If not I'll resubmit the series tonight or tomorrow morning with the functions renamed as suggested above. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists