linux-kernel - Re: [PATCH 1/1] scripts/get_maintainer: increase threshold for --follow to reduce time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2014 21:08:42 -0700
From:	Joe Perches <joe@...ches.com>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] scripts/get_maintainer: increase threshold for
 --follow to reduce time

On Tue, 2014-07-15 at 22:23 -0400, Pranith Kumar wrote:
> ping?
> 
> On Sat, Jul 12, 2014 at 3:25 PM, Pranith Kumar <bobby.prani@...il.com> wrote:
> > get_maintainer tries to follow files with a matching threshold of default 50%.
> > This is not really necessary as we do not change a file and move it in the same
> > commit usually. Increasing the threshold to 90% should be sufficient.
[]
> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> > index d701627..bc4a69e 100755
> > --- a/scripts/get_maintainer.pl
> > +++ b/scripts/get_maintainer.pl
> > @@ -98,7 +98,7 @@ my %VCS_cmds_git = (
> >      "execute_cmd" => \&git_execute_cmd,
> >      "available" => '(which("git") ne "") && (-e ".git")',
> >      "find_signers_cmd" =>
> > -       "git log --no-color --follow --since=\$email_git_since " .
> > +       "git log --no-color --follow -M90 --since=\$email_git_since " .
> >             '--numstat --no-merges ' .
> >             '--format="GitCommit: %H%n' .
> >                       'GitAuthor: %an <%ae>%n' .

While I understand the goal, I wonder if this should
be in a .gitconfig, not in get_maintainers at all.

(git doesn't seem to have a config entry for score though)

If not, the % should probably be cmd-line configurable.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/