linux-kernel - Re: [Bug report] Hit false positives bug with script/checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2014 21:20:32 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ethan Zhao <ethan.zhao@...cle.com>
Cc:	anish@...lsio.com, apw@...onical.com, linux-kernel@...r.kernel.org,
	ethan.kernel@...il.com, joe.jin@...cle.com
Subject: Re: [Bug report] Hit false positives bug with script/checkpatch.pl

On Wed, 2014-07-16 at 10:50 +0800, Ethan Zhao wrote:
> Hi,
>      I hit a false positives bug when run script/checkpatch.pl to my patch,
> It reported  errors to following macro definition, but in fact the macro is
> correct, I couldn't change that macro according to the error message output
> by script/checkpatch.pl. because of this bug, my patch was rejected by some
> guy's patchwork.

You could tell the guy checkpatch isn't always right.

You could also change the macro to something like:

#define NETXEN_NIC_STAT(name, m)				\
{								\
	.name = name,						\
	.type = m,						\
	.sizeof_stat = FIELD_SIZEOF(struct netxen_adapter, m),	\
	.stat_offset = offsetof(struct netxen_adapter, m)	\
}

and change the uses like:

static const struct netxen_nic_stats netxen_nic_gstrings_stats[] = {
	NETXEN_NIC_STAT("xmit called", stats.xmitcalled),
	NETXEN_NIC_STAT("xmit_finished", stats.xmitfinished),

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/