linux-kernel - Re: [patch 51/55] clocksource: Make delta calculation a function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1407160857320.24854@nanos>
Date:	Wed, 16 Jul 2014 08:58:09 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	John Stultz <john.stultz@...aro.org>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [patch 51/55] clocksource: Make delta calculation a function

On Tue, 15 Jul 2014, John Stultz wrote:

> On Fri, Jul 11, 2014 at 6:45 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> > @@ -335,16 +335,15 @@ static void timekeeping_update(struct ti
> >   */
> >  static void timekeeping_forward_now(struct timekeeper *tk)
> >  {
> > -       cycle_t cycle_now, cycle_delta;
> > +       cycle_t cycle_now, delta;
> >         struct clocksource *clock;
> >         s64 nsec;
> >
> >         clock = tk->clock;
> >         cycle_now = clock->read(clock);
> > -       cycle_delta = (cycle_now - clock->cycle_last) & clock->mask;
> > -       tk->cycle_last = clock->cycle_last = cycle_now;
> > +       delta = clocksource_delta(cycle_now, clock->cycle_last, clock->mask);
> 
> Errr.. Was dropping the update to tk->cycle_last and clock->cycle_last
> intended? That seems broken.

Grr, was definitely not intended.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/