linux-kernel - Re: [PATCH v2 22/29] nios2: Miscellaneous header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFiDJ58ZPQ0aMrYFv5g-ThgEt4AVFQp0yhCRb+hzJxV2i4Rjyw@mail.gmail.com>
Date:	Wed, 16 Jul 2014 15:03:12 +0800
From:	Ley Foon Tan <lftan@...era.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Linux-Arch <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Chung-Lin Tang <cltang@...esourcery.com>
Subject: Re: [PATCH v2 22/29] nios2: Miscellaneous header files

On Tue, Jul 15, 2014 at 6:22 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 15 July 2014 16:45:49 Ley Foon Tan wrote:
>> diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h
>> new file mode 100644
>> index 0000000..e726bfc
>> --- /dev/null
>> +++ b/arch/nios2/include/asm/gpio.h

> This seems wrong. If any device drivers rely on this, better fix them to
> use linux/gpio.h directly.
Okay, will remove this file.


>> +#ifndef __ASM_NIOS2_PCI_H__
>> +#define __ASM_NIOS2_PCI_H__
>> +
>> +/* We don't support PCI yet, but some drivers require this file anyway */
>> +
>> +#endif /* __ASM_NIOS2_PCI_H__ */
>
> What's wrong with the generic version?
Change to use generic pci.h.

>
>> +#ifndef _UAPI_ASM_NIOS2_STAT_H
>> +#define _UAPI_ASM_NIOS2_STAT_H
>> +
>> +#include <asm-generic/stat.h>
>> +
>> +#endif
>
> This should just use the Kconfig logic to fall back on the generic file.
Will use generic file.

Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/