linux-kernel - Re: Bug_ON with patch: bio: modify __bio_add_page() to accept pages that don't start a new segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C62F95.3020001@kernel.dk>
Date:	Wed, 16 Jul 2014 09:53:57 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Maurizio Lombardi <mlombard@...hat.com>,
	Mike Qiu <qiudayu@...ux.vnet.ibm.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ming.lei@...onical.com" <ming.lei@...onical.com>,
	"dongsu.park@...fitbricks.com" <dongsu.park@...fitbricks.com>,
	"jet.chen@...el.com" <jet.chen@...el.com>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"hch@....de" <hch@....de>, "kmo@...erainc.com" <kmo@...erainc.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"axboe@...com" <axboe@...com>
Subject: Re: Bug_ON with patch: bio: modify __bio_add_page() to accept pages
 that don't start a new segment

On 2014-07-16 08:51, Maurizio Lombardi wrote:
> Hi,
>
> On 07/15/2014 10:44 AM, Maurizio Lombardi wrote:
>>> I have reverted it yesterday in my tree.
>>>
>>
>>
>> The problem was here:
>>
>>          if (q->merge_bvec_fn) {
>>                  struct bvec_merge_data bvm = {
>>                          .bi_bdev = bio->bi_bdev,
>>                          .bi_sector = bio->bi_iter.bi_sector,
>>                          .bi_size = bio->bi_iter.bi_size, <-------
>>                          .bi_rw = bio->bi_rw,
>>                  };
>>
>>                  /*
>>                   * merge_bvec_fn() returns number of bytes it can accept
>>                   * at this offset
>>                   */
>>                  if (q->merge_bvec_fn(q, &bvm, bvec) < bvec->bv_len)
>>                          goto failed;
>>          }
>>
>>          /* If we may be able to merge these biovecs, force a recount */
>>          if (bio->bi_vcnt > 1 && (BIOVEC_PHYS_MERGEABLE(bvec-1, bvec)))
>>                  bio->bi_flags &= ~(1 << BIO_SEG_VALID);
>>
>>
>> it should have been ".bi_size = bio->bi_iter.bi_size - len"
>>
>
> Jens, will you restore the patch in your tree if I submit
> this fix?

Sure, we can try again, hopefully this will be the last of them.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/