linux-kernel - RE: [PATCH v5] mtd:nor:timeout:fix do_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLU185-W44C89261B8307EBFCC2EC0A6F70@phx.gbl>
Date:	Wed, 16 Jul 2014 08:48:49 +0000
From:	Bean Huo <beanhuo@...look.com>
To:	Jingoo Han <jg1.han@...sung.com>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"computersforpeace@...il.com" <computersforpeace@...il.com>
CC:	"paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>,
	"artem.bityutskiy@...ux.intel.com" <artem.bityutskiy@...ux.intel.com>,
	"b32955@...escale.com" <b32955@...escale.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"christian.riesch@...cron.at" <christian.riesch@...cron.at>
Subject: RE: [PATCH v5] mtd:nor:timeout:fix do_write_buffer() timeout error

>> + if (cfi->cfiq->BufWriteTimeoutTyp &&
>> + cfi->cfiq->BufWriteTimeoutMax){
>> + cfi->chips[i].buffer_write_time_max =
>> + 1<<(cfi->cfiq->BufWriteTimeoutTyp +
>> + cfi->cfiq->BufWriteTimeoutMax);
>> + } else {
>> + cfi->chips[i].buffer_write_time_max = 0;
>> + }
>
> Please keep the coding style as below.
>
> if ( ) {
> ...
> } else {
> ...
> }
>

If I keep coding style as above.this will be beyond the requirements of one line length.
I also saw othter files use the same code style as mine.please see:cfi_cmdset_0001.c

if (cfi->cfiq->WordWriteTimeoutTyp &&
     cfi->cfiq->WordWriteTimeoutMax)
        cfi->chips[i].word_write_time_max =
		1<<(cfi->cfiq->WordWriteTimeoutTyp +
		      cfi->cfiq->WordWriteTimeoutMax);
else
      cfi->chips[i].word_write_time_max = 50000 * 8;

Note: beacuse I cann't send mail by git in office,I send this patch by web mail client.So,
there still a error stype in this patch(web mail client will remove some spaces),that is one space required before that '>='.I will send again this patch at home.
For your coding style advice, I will take into account,but i don't know if can put one line. 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/