linux-kernel - Re: [PATCH] drivers/rtc/rtc-isl12022.c: Device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140716085904.GA26951@leverpostej>
Date:	Wed, 16 Jul 2014 09:59:04 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Stuart Longland <stuartl@....com.au>
Cc:	Roman Fietze <roman.fietze@...emotive.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] drivers/rtc/rtc-isl12022.c: Device tree support

On Wed, Jul 16, 2014 at 03:28:25AM +0100, Stuart Longland wrote:
> Add some support for configuring isl12020/isl12022 devices using the
> Device Tree blob.
> 
> Signed-off-by: Stuart Longland <stuartl@....com.au>

Please document this as with isl,isl12057, in
Documentation/devicetree/bindings/i2c/trivial-devices.txt

The string itself looks fine.

> ---
>  drivers/rtc/rtc-isl12022.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c
> index 03b8911..aa55f08 100644
> --- a/drivers/rtc/rtc-isl12022.c
> +++ b/drivers/rtc/rtc-isl12022.c
> @@ -17,6 +17,8 @@
>  #include <linux/slab.h>
>  #include <linux/module.h>
>  #include <linux/err.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
>  
>  #define DRV_VERSION "0.1"
>  
> @@ -271,6 +273,13 @@ static int isl12022_probe(struct i2c_client *client,
>  	return PTR_ERR_OR_ZERO(isl12022->rtc);
>  }
>  
> +#ifdef CONFIG_OF
> +static struct of_device_id isl12022_dt_match[] = {
> +	{ .compatible = "isl,isl12022" },
> +	{ },
> +};
> +#endif
> +
>  static const struct i2c_device_id isl12022_id[] = {
>  	{ "isl12022", 0 },
>  	{ }
> @@ -280,6 +289,9 @@ MODULE_DEVICE_TABLE(i2c, isl12022_id);
>  static struct i2c_driver isl12022_driver = {
>  	.driver		= {
>  		.name	= "rtc-isl12022",
> +#ifdef CONFIG_OF
> +		.of_match_table = of_match_ptr(isl12022_dt_match),
> +#endif

You can drop the ifdef here, of_match_ptr(x) is NULL if !CONFIG_OF.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/