linux-kernel - Re: [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5513748.05vsM1lCJN@avalon>
Date:	Wed, 16 Jul 2014 11:53:21 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Xiang Wang <wangxfdu@...il.com>, Xiang Wang <wangx@...vell.com>
Cc:	Chris Ball <chris@...ntf.net>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Marcin Wojtas <mw@...ihalf.com>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Chao Xie <cxie4@...vell.com>
Subject: Re: [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host

Hi Xiang,

Thank you for the patch.

On Wednesday 16 July 2014 15:50:09 Xiang Wang wrote:
> From: Xiang Wang <wangx@...vell.com>
> 
> Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error
> handling of sdhci_add_host. However, "err_of_parse" and "err_cd_req"
> should be placed after "pm_runtime_disable(&pdev->dev)".
> 
> Signed-off-by: Xiang Wang <wangx@...vell.com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

While we're touching the probe error path, how about converting the driver to 
the devm_* helpers ? I'll send a patch shortly.

> ---
>  drivers/mmc/host/sdhci-pxav3.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index 2fd73b3..0644655 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -380,11 +380,11 @@ static int sdhci_pxav3_probe(struct platform_device
> *pdev)
> 
>  	return 0;
> 
> -err_of_parse:
> -err_cd_req:
>  err_add_host:
>  	pm_runtime_put_sync(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
> +err_of_parse:
> +err_cd_req:
>  	clk_disable_unprepare(clk);
>  	clk_put(clk);
>  err_clk_get:

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/