linux-kernel - Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C66AEB.7030906@mm-sol.com>
Date:	Wed, 16 Jul 2014 15:07:07 +0300
From:	Stanimir Varbanov <svarbanov@...sol.com>
To:	pramod.gurav.etc@...il.com
CC:	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	Josh Cartwright <joshc@...eaurora.org>,
	Mark Brown <broonie@...aro.org>
Subject: Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

Hi,

<snip>
> 
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@...il.com>
> CC: Josh Cartwright <joshc@...eaurora.org>
> CC: Mark Brown <broonie@...aro.org>
> ---
> This was found when I enabled support for Qualcomm QPNP PMICs and was
> compiling it. It selects REGMAP_SPMI and hence the crash.
> 
>  drivers/base/regmap/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index 4251570..1aa9d71 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -16,6 +16,7 @@ config REGMAP_SPI
>  	tristate
>  
>  config REGMAP_SPMI
> +	select SPMI

NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and
multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example.

-- 
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/