linux-kernel - Re: [PATCH 04/19] serial: samsung: Remove support for legacy clock code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <53C67386.5070401@samsung.com>
Date:	Wed, 16 Jul 2014 14:43:50 +0200
From:	Tomasz Figa <t.figa@...sung.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Kukjin Kim <kgene.kim@...sung.com>,
	Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Mark Brown <broonie@...nel.org>,
	Heiko Stübner <heiko@...ech.de>,
	Tomasz Figa <tomasz.figa@...il.com>
Subject: Re: [PATCH 04/19] serial: samsung: Remove support for legacy clock code

On 16.07.2014 11:27, Paul Bolle wrote:
> On Fri, 2014-07-04 at 19:48 +0200, Tomasz Figa wrote:
>> All Samsung platforms are now using the Common Clock Framework and the
>> legacy clock code is being removed, so remove related dead code from
>> samsung-serial driver as well.
>>
>> Reported-by: Arnd Bergmann <arnd@...db.de>
>> Signed-off-by: Tomasz Figa <t.figa@...sung.com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> (maintainer:SERIAL DRIVERS)
>> Cc: Jiri Slaby <jslaby@...e.cz> (supporter:TTY LAYER)
>> Cc: linux-serial@...r.kernel.org (open list:SERIAL DRIVERS)
>> ---
>>  drivers/tty/serial/samsung.c | 4 ----
>>  1 file changed, 4 deletions(-)
> 
> This just entered linux-next (see next-20140716).
> 
>> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
>> index 36c7747..cae8ebd 100644
>> --- a/drivers/tty/serial/samsung.c
>> +++ b/drivers/tty/serial/samsung.c
>> @@ -47,10 +47,6 @@
>>  
>>  #include <asm/irq.h>
>>  
>> -#ifdef CONFIG_SAMSUNG_CLOCK
>> -#include <plat/clock.h>
>> -#endif
>> -
>>  #include "samsung.h"
>>  
>>  #if	defined(CONFIG_SERIAL_SAMSUNG_DEBUG) &&	\
> 
> There are three further references to CONFIG_SAMSUNG_CLOCK in this file.
> Those should be removed too, shouldn't they?

That's right. Apparently I missed them. I guess that's not critical,
though, and could be done in separate patch, right?

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/