lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Jul 2014 05:47:29 -0700 From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> To: Pranith Kumar <bobby.prani@...il.com> Cc: josh@...htriplett.org, Steven Rostedt <rostedt@...dmis.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Lai Jiangshan <laijs@...fujitsu.com>, "open list:READ-COPY UPDATE..." <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/3] rcu: Remove stale comment in tree.c On Tue, Jul 15, 2014 at 06:57:59PM -0400, Pranith Kumar wrote: > > On 07/15/2014 06:53 PM, josh@...htriplett.org wrote: > > On Tue, Jul 15, 2014 at 06:31:48PM -0400, Pranith Kumar wrote: > >> This commit removes a stale comment in rcu/tree.c. > >> FYI, an updated comment exists a few lines below this. > >> > >> Signed-off-by: Pranith Kumar <bobby.prani@...il.com> > > In general, when removing a stale comment, I'd suggest explaining why > > the comment is stale. Was code removed without removing the > > corresponding comment, or was code changed such that the comment no > > longer applies, or...? > > I guess it was left out when code was moved around previously. And I did mention that an updated comment is there a few lines below. > > For reference this is the new comment which is below the old comment, they mean the same :) > > /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */ Indeed that is the case. Please update the commit log with this explanation and resend. Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists