linux-kernel - Re: [Patch V3 00/16] Enable support of IOAPIC hotplug on x86 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Jul 2014 09:33:05 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Yinghai Lu <yinghai@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Luck <tony.luck@...el.com>,
	Joerg Roedel <joro@...tes.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [Patch V3 00/16] Enable support of IOAPIC hotplug on x86
 platforms

On Wed, Jul 16, 2014 at 11:01:45AM +0800, Jiang Liu wrote:
> Hi Konrad,

Hey Jiang,
> 	We have found the root cause with your great support. If BIOS
> assigns an IRQ number for a PCI device, acpi_pci_irq_enable() fails to

I would think that is a common scenario?

> assign IOAPIC IRQ then due to the check:
>         if (dev->irq > 0)
>                 return 0;

I should really look in the code to figure this out - but I think your
patch will have a detail analysis that will make tglrx happy, so
will just wait till then :-)

> 	For a quick workaround, just comment out above check. But we
> need some time to figure out a clean fixup for it. We will send out new
> version once it gets resolved.

Excellent. Once you do, please do give me the git tree so I can slurp
it in my testing

> 	Thanks for your great help again.

Of course! Thank you for your quick turn-around.
> Regards!
> Gerry
> On 2014/7/16 0:10, Konrad Rzeszutek Wilk wrote:
> > already assigned IRQ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/