linux-kernel - Re: [PATCH qemu] i386,linux-headers: Add support for kvm_get_rng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Jul 2014 18:17:11 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Andy Lutomirski <luto@...capital.net>, kvm@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>, Theodore Ts'o <tytso@....edu>,
	linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
	x86@...nel.org, qemu-devel@...gnu.org
CC:	Daniel Borkmann <dborkman@...hat.com>,
	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>,
	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
Subject: Re: [PATCH qemu] i386,linux-headers: Add support for kvm_get_rng_seed

Il 16/07/2014 17:52, Andy Lutomirski ha scritto:
> This updates x86's kvm_para.h for the feature bit definition and
> target-i386/cpu.c for the feature name and default.
>
> Signed-off-by: Andy Lutomirski <luto@...capital.net>

Thanks, looks good---assuming the kernel side will make it into 3.17, 
I'll sync the headers once 3.17 is released and then apply the patch. 
As mentioned in kvm@ someone will have to add the pc-2.2 machine type too.

Paolo

> ---
>  linux-headers/asm-x86/kvm_para.h | 2 ++
>  target-i386/cpu.c                | 5 +++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/linux-headers/asm-x86/kvm_para.h b/linux-headers/asm-x86/kvm_para.h
> index e41c5c1..a9b27ce 100644
> --- a/linux-headers/asm-x86/kvm_para.h
> +++ b/linux-headers/asm-x86/kvm_para.h
> @@ -24,6 +24,7 @@
>  #define KVM_FEATURE_STEAL_TIME		5
>  #define KVM_FEATURE_PV_EOI		6
>  #define KVM_FEATURE_PV_UNHALT		7
> +#define KVM_FEATURE_GET_RNG_SEED	8
>
>  /* The last 8 bits are used to indicate how to interpret the flags field
>   * in pvclock structure. If no bits are set, all flags are ignored.
> @@ -40,6 +41,7 @@
>  #define MSR_KVM_ASYNC_PF_EN 0x4b564d02
>  #define MSR_KVM_STEAL_TIME  0x4b564d03
>  #define MSR_KVM_PV_EOI_EN      0x4b564d04
> +#define MSR_KVM_GET_RNG_SEED 0x4b564d05
>
>  struct kvm_steal_time {
>  	__u64 steal;
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 8fd1497..4ea7e6c 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -236,7 +236,7 @@ static const char *ext4_feature_name[] = {
>  static const char *kvm_feature_name[] = {
>      "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock",
>      "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", "kvm_pv_unhalt",
> -    NULL, NULL, NULL, NULL,
> +    "kvm_get_rng_seed", NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
> @@ -368,7 +368,8 @@ static uint32_t kvm_default_features[FEATURE_WORDS] = {
>          (1 << KVM_FEATURE_ASYNC_PF) |
>          (1 << KVM_FEATURE_STEAL_TIME) |
>          (1 << KVM_FEATURE_PV_EOI) |
> -        (1 << KVM_FEATURE_CLOCKSOURCE_STABLE_BIT),
> +        (1 << KVM_FEATURE_CLOCKSOURCE_STABLE_BIT) |
> +        (1 << KVM_FEATURE_GET_RNG_SEED),
>      [FEAT_1_ECX] = CPUID_EXT_X2APIC,
>  };
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/