linux-kernel - Re: find_busiest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140716175259.GA5956@gmail.com>
Date:	Wed, 16 Jul 2014 12:52:59 -0500
From:	Greg Donald <gdonald@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>
Subject: Re: find_busiest_group divide error

On Wed, Jul 16, 2014 at 05:27:36PM +0200, Peter Zijlstra wrote:
> Could you confirm if reverting caffcdd8d27ba78730d5540396ce72ad022aff2c
> cures things for you?
> 
> Otherwise there's two very similar issues, see also:
> 
>    lkml.kernel.org/r/20140716145546.GA6922@...ff.to

Cured.

I reverted caffcdd8d27ba78730d5540396ce72ad022aff2c which did nothing as
far as I can tell, then I removed the
two lines from http://marc.info/?l=linux-kernel&m=140552264825755, then
I added back the one line from
https://bugzilla.kernel.org/show_bug.cgi?id=80251#c8.

I ended up with

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index dc2927c..7c3674d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5848,7 +5848,6 @@ build_sched_groups(struct sched_domain *sd, int
cpu)
 
                group = get_group(i, sdd, &sg);
                cpumask_clear(sched_group_cpus(sg));
-               sg->sgp->power = 0;
                cpumask_setall(sched_group_mask(sg));
 
                for_each_cpu(j, span) {


Thanks.

-- 
Greg Donald

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)