linux-kernel - Re: [PATCH v2 12/29] nios2: Interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFiDJ5_dTKXSVPtr20uDU32=v_jb3NKUDHGw4OFjW6DuvoZyeA@mail.gmail.com>
Date:	Thu, 17 Jul 2014 14:15:44 +0800
From:	Ley Foon Tan <lftan@...era.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Linux-Arch <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Chung-Lin Tang <cltang@...esourcery.com>
Subject: Re: [PATCH v2 12/29] nios2: Interrupt handling

On Tue, Jul 15, 2014 at 5:27 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 15 July 2014 16:45:39 Ley Foon Tan wrote:
>> +#ifndef _ASM_NIOS2_IRQ_H
>> +#define _ASM_NIOS2_IRQ_H
>> +
>> +#define NIOS2_CPU_NR_IRQS    32
>> +/* Reserve 32 additional interrupts for GPIO IRQs */
>> +#define NR_IRQS                      (NIOS2_CPU_NR_IRQS + 32)
>
> Is this intentional? I would expect that you use SPARSE_IRQ
> instead and not define NR_IRQS.
Okay, will change to use SPARSE_IRQ.
>
>> +#ifndef NO_IRQ
>> +#define NO_IRQ                       (-1)
>> +#endif
>
> New architectures should no longer define NO_IRQ. Please fix all users
> you encounter instead.
Okay.

>
>> diff --git a/arch/nios2/kernel/irq.c b/arch/nios2/kernel/irq.c
>> new file mode 100644
>> index 0000000..8770d50
>> --- /dev/null
>> +++ b/arch/nios2/kernel/irq.c
>> +#include <linux/init.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/of.h>
>
> Maybe move this into drivers/irqchip/? Probably doesn't matter either way,
> your choice.
Will keep it here.
BTW, this interrupt controller is part of Nios2 cpu architecture.
Should we move to drivers/irqchip/ if that's the case? Any example of
arch doing this?
Thanks.

Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/