lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Jul 2014 11:16:56 +0200 From: Tom Gundersen <teg@...m.no> To: Johannes Berg <johannes@...solutions.net> Cc: netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, LKML <linux-kernel@...r.kernel.org>, John Linville <linville@...driver.com> Subject: Re: [PATCH net-next v9 2/9] net: nl80211 - make rdev_add_virtual_intf take name_assign_type On Thu, Jul 17, 2014 at 11:04 AM, Johannes Berg <johannes@...solutions.net> wrote: > On Thu, 2014-07-17 at 10:06 +0200, Tom Gundersen wrote: >> Pass the value down and set it at the same place the name itself is set. > > Huh? What's this? Can you explain why? Sure, sorry the context got lost. We want to expose the origin of ifnames so that udev can better decide whether or not to rename them. In particular, this patch will allow udev to tell that it should no longer rename Wifi-P2P devices, which is currently a problem. A general overview is in the patch introducing the interface: <http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=685343fc3ba61a1f6eef361b786601123db16c28>. >> static struct wireless_dev *ath6kl_cfg80211_add_iface(struct wiphy *wiphy, >> const char *name, >> + unsigned char name_assign_type, > > unsigned char for an enum is really odd. Hm, this was based on the addr_assign_type attribute, which also is an unsigned char (and serves a very similar purpose). Out of interest, what would you have preferred (and why)? Cheers, Tom -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists