lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140717091601.GF25880@mwanda> Date: Thu, 17 Jul 2014 12:16:02 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Chen Gang <gang.chen.5i5j@...il.com> Cc: Thierry Reding <thierry.reding@...il.com>, linux-iio@...r.kernel.org, Benjamin Herrenschmidt <benh@...nel.crashing.org>, teg@...m.no, Lennox Wu <lennox.wu@...il.com>, Marek Vasut <marex@...x.de>, Liqin Chen <liqin.linux@...il.com>, Lars-Peter Clausen <lars@...afoo.de>, Richard Weinberger <richard@....at>, Geert Uytterhoeven <geert@...ux-m68k.org>, msalter@...hat.com, Guenter Roeck <linux@...ck-us.net>, linux-pwm@...r.kernel.org, devel@...verdev.osuosl.org, linux-watchdog@...r.kernel.org, arnd@...db.de, linux-input@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, dmitry.torokhov@...il.com, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, knaack.h@....de, Martin Schwidefsky <schwidefsky@...ibm.com>, Mischa.Jonker@...opsys.com, jic23@...nel.org Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource' On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: > >> + return (__force void __iomem *)ERR_PTR(-ENXIO); > > > > There's apparently an IOMEM_ERR_PTR() for this nowadays... > > > > IOMEM_ERR_PTR() is defined within "lib/devres.c", not in "./include". > But may we move it from "lib/devres.c" to "./include/linux/err.h"? > > For me, I am not quite sure, it may need additional discussion, but at > least, that will be another patch. Yes. Move it there. That is the right place. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists